Change in ovirt-engine[ovirt-engine-3.4]: core: Add validation for Vm memory hard limits
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Add validation for Vm memory hard limits
......................................................................
core: Add validation for Vm memory hard limits
The vdc options VM64BitMaxMemorySizeInMB and VM64BitMaxMemorySizeInMB
were not checked at all, only the os-info were used to issue a warning.
Now we check those against the appropriate cluster version at the VM
run.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1104774
Change-Id: I46c22acc77867abc79cd54ef6113ab2da005fd94
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 62 insertions(+), 1 deletion(-)
Approvals:
Martin Betak: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46c22acc77867abc79cd54ef6113ab2da005fd94
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server