Change in ovirt-engine[master]: core: move VmCommand#removeVmInSpm method
Omer Frenkel has submitted this change and it was merged.
Change subject: core: move VmCommand#removeVmInSpm method
......................................................................
core: move VmCommand#removeVmInSpm method
Move VmCommand#removeVmInSpm method to RemoveVmFromImportExportCommand
class as it is the only place where this method is called from.
The code which is related to disk images removal is extracted from the
execute method of RemoveVmFromImportExportCommand to separate method.
In addition, minor refactoring is made in the canDoAction method of
RemoveVmFromImportExportCommand.
Change-Id: Id3945268925fb5f1541fa29c9ef24e97fc243228
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
2 files changed, 26 insertions(+), 20 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/16709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3945268925fb5f1541fa29c9ef24e97fc243228
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server