Change in ovirt-engine[master]: engine: Consider removed bonds in CollectVdsNetworkData
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Consider removed bonds in CollectVdsNetworkData
......................................................................
engine: Consider removed bonds in CollectVdsNetworkData
Changes to removed bonds should also be considered in the
CollectVdsNetworkData command, because they won't necessarily be torn
down by VDSM, in which case their label changes should still be
persisted.
There existed code to clear labels from removed bonds in
SetupNetworksCommand, but it was pretty much dead code, as removed
bonds by definition don't appear in the passed interfaces collection.
Change-Id: I44f1d5c0702e5062fe29bc89e12ff2400b46921b
Bug-Url: https://bugzilla.redhat.com/1085819
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
3 files changed, 14 insertions(+), 24 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44f1d5c0702e5062fe29bc89e12ff2400b46921b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server