Change in ovirt-engine[ovirt-engine-3.5-gluster]: webadmin: UI plugins - control tab priority
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: UI plugins - control tab priority
......................................................................
webadmin: UI plugins - control tab priority
When adding custom main or sub tab, UI plugins can now specify
the priority of the tab, denoting its relative position within
the tab panel.
Standard main and sub tabs typically have their priority starting
at 0 (left-most tab) and incremented by 1 for each next tab. For
example, "DataCenter" main tab priority is 0, "Cluster" main tab
priority is 1, and so on.
Example usage:
api.addMainTab('Test', 'test-tab',
'plugin/TestPlugin/tab.html',
// tab options object, as documented at
// http://www.ovirt.org/Features/UIPlugins#Main_and_sub_tabs
{
priority: -1 // position this tab before all standard ones
}
);
This patch also improves priority comparison in AbstractTabPanel
to account for rounding procedure, e.g. representing real numbers
in a floating point number system.
Change-Id: I1251ccbe7b3cfbb378fa31ef6009184216409265
Bug-Url: https://bugzilla.redhat.com/1214624
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/FloatingPointHelper.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/AbstractTabPanel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/TabOptions.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/DynamicUrlContentTabProxyFactory.java
5 files changed, 85 insertions(+), 5 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/41032
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1251ccbe7b3cfbb378fa31ef6009184216409265
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5-gluster
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org