Change in ovirt-engine[master]: core: pass dependencies of vm-analyzer using the ctor
Arik Hadas has submitted this change and it was merged.
Change subject: core: pass dependencies of vm-analyzer using the ctor
......................................................................
core: pass dependencies of vm-analyzer using the ctor
Pass the dependencies of VmAnalyzer using its constructor
rather than using setters in order to simplify the code.
Note that some of dependencies can be injected but it since
there might be a lot of VMs running on each host, we prefer
to inject them once in the factory and pass their reference
instead.
Change-Id: Ib347bf5e6da59ce1e3f0fa57130a7e6294c1ff3f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java
4 files changed, 145 insertions(+), 109 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53167
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib347bf5e6da59ce1e3f0fa57130a7e6294c1ff3f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>