Change in ovirt-engine[master]: userportal, webadmin: Update messages locale test
Alexander Wels has submitted this change and it was merged.
Change subject: userportal,webadmin: Update messages locale test
......................................................................
userportal,webadmin: Update messages locale test
- Added unit test that checks if the parameters in the
translation files match the prototype for UIMessages
- Updated regex to match prototype place holders to include
lists
- Excluded @Select parameters from being in the required count
- Fixed issue in UIMessages_pt_BR where the place holder got
translated by mistake.
Change-Id: I534acbd5de42eb5c0d759debefd16dd78203bab9
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/pom.xml
M
frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/CommonApplicationMessagesTest.java
M frontend/webadmin/modules/uicompat/pom.xml
M
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_pt_BR.properties
R
frontend/webadmin/modules/uicompat/src/test/java/org/ovirt/engine/ui/uicompat/GwtMessagesValidator.java
A
frontend/webadmin/modules/uicompat/src/test/java/org/ovirt/engine/ui/uicompat/UIMessagesTest.java
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M
frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/ApplicationMessagesTest.java
M frontend/webadmin/modules/webadmin/pom.xml
M
frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/ApplicationMessagesTest.java
10 files changed, 45 insertions(+), 8 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50556
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I534acbd5de42eb5c0d759debefd16dd78203bab9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>