Alona Kaplan has submitted this change and it was merged.
Change subject: core: duplicate fixes, simplifications, few inspections fixed.
......................................................................
core: duplicate fixes, simplifications, few inspections fixed.
• fixed unnecessary type parameters
• removed unnecessary array creation when calling varargs method
• added missing space before {
• extracted duplicate bond creation and used method for that
• extracted duplicate string literals to variable
• Arrays.asList(oneItem) —> Collections.singletonList(oneItem).
Change-Id: I3421a533f24e7ad7685878b103776639f23f6732
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java
1 file changed, 62 insertions(+), 51 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/48533
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3421a533f24e7ad7685878b103776639f23f6732
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>