Change in ovirt-engine[ovirt-engine-3.5]: core: Enable single-entry MAC range in engine-config
Tal Nisan has submitted this change and it was merged.
Change subject: core: Enable single-entry MAC range in engine-config
......................................................................
core: Enable single-entry MAC range in engine-config
This was previously wrongly blocked. It also seems like the utility
class blocking this had another logical issue - in cases where
multiple ranges need to be handled (I don't see that this can happen
at the moment but the code seems to take that into consideration),
true would be returned if at least one of the ranges were valid -
instead of false being returned if at least one of the ranges were
invalid.
Change-Id: I0e439d1b60cc15792ad7e3ce6596f65a78c81b48
Bug-Url: https://bugzilla.redhat.com/1126181
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M
backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Lior Vernia: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/31058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e439d1b60cc15792ad7e3ce6596f65a78c81b48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server