Change in ovirt-engine[master]: core: Avoid potential NPE in "SSHDialog"
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Avoid potential NPE in "SSHDialog"
......................................................................
core: Avoid potential NPE in "SSHDialog"
This is needed in order to avoid the following findbugs warning:
Possible null pointer dereference in method on exception path
A reference value which is null on some exception control path is
dereferenced here. This may lead to a NullPointerException when the
code is executed. Note that because FindBugs currently does not prune
infeasible exception paths, this may be a false warning.
Also note that FindBugs considers the default case of a switch statement
to be an exception path, since the default case is often infeasible.
Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_EXCEPTION
Change-Id: I598c3c490a9b6c152ac0245b7b89842081b16b01
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I598c3c490a9b6c152ac0245b7b89842081b16b01
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org