Change in ovirt-engine[master]: engine: Storage validation in LSM flow
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Storage validation in LSM flow
......................................................................
engine: Storage validation in LSM flow
The patch I9f42f387781425d16f53a0e8a34d859365808ec0 introduced a change
that the disks validated in CreateAllSnapshotsFromVmCommand are all
the snappable disks.
This patch is reverting the mentioned above.
We need to check only the disks that the user selected.
LSM flow uses also CreateAllSnapshotsFromVmCommand.
In this case, the disks are already validated in the LSM command,
no need to check them again.
Change-Id: I0bb0aa45f54824ed93e299827c3f38c0905bb3cd
Bug-Url: https://bugzilla.redhat.com/1282957
Bug-Url: https://bugzilla.redhat.com/1287025
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
2 files changed, 12 insertions(+), 17 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/49446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bb0aa45f54824ed93e299827c3f38c0905bb3cd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>