Sandro Bonazzola has submitted this change and it was merged.
Change subject: tools: Match transport names with EventNotificationMethod
......................................................................
tools: Match transport names with EventNotificationMethod
Fixes different names in Smtp/Snmp.getName() and
EventNotificationMethod values which represents transport names in db.
If those names differ (current state), no events are sent through
notifier.
Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e
Bug-Url:
https://bugzilla.redhat.com/1071536
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationMethod.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EventDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/smtp/Smtp.java
M
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java
A packaging/dbscripts/upgrade/03_04_0650_fix_event_notfication_method.sql
10 files changed, 54 insertions(+), 17 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Verified
Eli Mesika: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/25313
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie93d2d371a6f29a33e32a776e74ada5f221cbb4e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org