Change in ovirt-engine[ovirt-engine-3.5]: core: Calculate storage format when adding an SD
Tal Nisan has submitted this change and it was merged.
Change subject: core: Calculate storage format when adding an SD
......................................................................
core: Calculate storage format when adding an SD
Removed the default V1 format from StorageDomainStatic's constructor so
it can be calculated when adding a domain without specifying the format
via REST.
The logic goes as follows:
- If the format is specified (as is the case in all the edit scenarios
as well as when adding a new domain via the GUI), leave it alone
- If it's a data domain, set the format to the format required by the
pool's version.
Note: Creating a domain by a host not attached to a pool is currently
NOT supported. This patch does not change that behavior, nor does it
handle this situation.
- If it's not a data domain, use V1 (i.e., preserve the old behavior).
Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99
Bug-Url: https://bugzilla.redhat.com/1120712
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAOTest.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDAOTest.java
4 files changed, 23 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/31348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server