Change in ovirt-engine[master]: core: Allow to create template from scratch
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Allow to create template from scratch
......................................................................
core: Allow to create template from scratch
This patch add the ability to create a template from a VmStatic object,
even if this is not an existing vm in the engine db.
basically patch does:
1. move all image related checks in canDoAction to one method
2. handle places assuming vm in db (vm lock and vm-device handling)
frontend changes to use this abillity are under development,
as part of instance types work.
Change-Id: Iac363613af778157a50be1f7a211896d70e18952
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java
3 files changed, 151 insertions(+), 93 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac363613af778157a50be1f7a211896d70e18952
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>