Change in ovirt-engine[master]: core: add MemoryUtils#createMemoryStateString method
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add MemoryUtils#createMemoryStateString method
......................................................................
core: add MemoryUtils#createMemoryStateString method
The implementation of "RAM Snapshots" feature introduced new places
where we need to create the string representation of memory state,
besides HibernateVmCommand. This patch reduce the duplication of code
that creates memory state string (the comma-separated string of IDs)
by introducing a new utility method which is responsible for the
String creation, and is now being called from all the relevant places.
In addition, the changeStorageDomainAndPoolInMemoryVolume method in
MemoryUtils class is renamed to changeStorageDomainAndPoolInMemoryState.
Change-Id: Id1fe579cba2e86d95dc4689c38f195db1ea70eab
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java
5 files changed, 21 insertions(+), 10 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1fe579cba2e86d95dc4689c38f195db1ea70eab
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server