Change in ovirt-engine[ovirt-engine-3.3]: userportal, webadmin: workaround for Firefox favicon bug
Itamar Heim has submitted this change and it was merged.
Change subject: userportal, webadmin: workaround for Firefox favicon bug
......................................................................
userportal, webadmin: workaround for Firefox favicon bug
Workaround for Firefox bug https://bugzilla.mozilla.org/show_bug.cgi?id=519028,
'change location.hash leads to location bar icon (favicon) disappearance.'
The symptom is that the favicon disappears in Firefox on the initial hashchange
when logging in.
The workaround is to simply detach and re-attach the favicon link element
on hashchange by overriding ApplicationPlaceManager.onValueChange, and only
in Firefox by checking the user-agent.
Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108
Bug-Url: https://bugzilla.redhat.com/999436
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/favicon.tag
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/WebAdminPlaceManager.java
4 files changed, 50 insertions(+), 7 deletions(-)
Approvals:
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server