Change in ovirt-engine[master]: restapi: Fix condition in "IconHelper"
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Fix condition in "IconHelper"
......................................................................
restapi: Fix condition in "IconHelper"
This is needed in order to avoid the following findbugs warning, but it
also looks like a real bug:
Repeated conditional tests
The code contains a conditional test is performed twice, one right
after the other (e.g., x == 0 || x == 0). Perhaps the second
occurrence is intended to be something else (e.g., x == 0 || y == 0).
Bug kind and pattern: RpC - RpC_REPEATED_CONDITIONAL_TEST
Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/IconHelper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org