Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Volume - validations fixed (#823277)
......................................................................
webadmin: Gluster Volume - validations fixed (#823277)
https://bugzilla.redhat.com/823277
1. A validation error will be shown in the bottom of the create
volume dialog if the user has not added any bricks.
2. Validation error will be shown if the user has not selected
any one of the transport types
3. Volume name cannot be empty, yellow frame will be shown if validation fails.
Change-Id: If1430c9b9674f1dbca2ceada1a34317715fc047a
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml
4 files changed, 39 insertions(+), 3 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/4649
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1430c9b9674f1dbca2ceada1a34317715fc047a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>