Change in ovirt-engine[master]: core: Avoid redundant VmDevice creation in HotPlugDiskToVmCo...
Tal Nisan has submitted this change and it was merged.
Change subject: core: Avoid redundant VmDevice creation in HotPlugDiskToVmCommandTest
......................................................................
core: Avoid redundant VmDevice creation in HotPlugDiskToVmCommandTest
The createDiskWrongPlug method creates a redundant VmDevice for the sole
purpose of making it plugged/unplugged, this can be done by simply using
the already existing VmDevice created in the setup and just changing it's
plugged status
Also the redundant mockVmDevice(false) was removed from createVirtIODisk
as an unplugged device is already mocked in the setup
Change-Id: Icf50857716f63706b85a05ce8390980dc2b4659a
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56423
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf50857716f63706b85a05ce8390980dc2b4659a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>