Change in ovirt-engine[master]: core: Cleanup in VmInfoBuilder
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Cleanup in VmInfoBuilder
......................................................................
core: Cleanup in VmInfoBuilder
Some java cleanup:
* Removed dependency on deprecated StringHelper class
* Solved a potentital NPE
* Made private helper methods static where possible
* Turned a method comment to javadoc format
Change-Id: I07c383278aac0178f33d0cb67d746960fb4adce9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 32 insertions(+), 27 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07c383278aac0178f33d0cb67d746960fb4adce9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>