Change in ovirt-hosted-engine-setup[master]: packaging: setup: improoving cloud-init config UX
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: improoving cloud-init config UX
......................................................................
packaging: setup: improoving cloud-init config UX
- asking about appliance location just after disk/cdrom/pxe
- asking about appliance root password only if generating
cloud-init ISO
- adding a warning if the user is not configuring the
appliance root password (there is no default one!)
- using an empty string to indicate that the user
doesn't want to set the appliance root password
(there is a bug in otopi which suddenly stops logging
if we try to filter a boolean value but we don't want
to fix it)
Change-Id: I8fc500e6324a81414e2a18047045ee0b4e3ff5e0
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py
M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py
2 files changed, 64 insertions(+), 38 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/42446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc500e6324a81414e2a18047045ee0b4e3ff5e0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org