Change in ovirt-engine[master]: core: invalid ValidationGroup used when record is identified...
Alona Kaplan has submitted this change and it was merged.
Change subject: core: invalid ValidationGroup used when record is identified by name
......................................................................
core: invalid ValidationGroup used when record is identified by name
In HostSetupNetworksCommand Bonds and NetworkAttachments can be
identified by either name of id. Probably for historic reasons
are all new or updated, Bonds or NetworkAttachments passed from
client (ui, rest) in same list, one for each type. On Bll we need to
separate them.
Currently there's a bug, which causes wrong ValidationGroup is used,
when validating NetworkAttachment for update, where record is
identified by name. Luckily, the only place where validationGroup is
used, is Network attachment:
@NetworkIdOrNetworkNameIsSet(groups = { CreateEntity.class, UpdateEntity.class })
and this validation will work equally for both usecases.
Change-Id: Ib95ad75353735f9a894624989d8d06b3eaf822b6
Bug-Url: https://bugzilla.redhat.com/1271220
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
1 file changed, 6 insertions(+), 7 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52541
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib95ad75353735f9a894624989d8d06b3eaf822b6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>