Change in ovirt-engine[master]: core, webadmin: add isVm and isTemplate methods to VmEntityType
Omer Frenkel has submitted this change and it was merged.
Change subject: core,webadmin: add isVm and isTemplate methods to VmEntityType
......................................................................
core,webadmin: add isVm and isTemplate methods to VmEntityType
Since now there are more types for VmEntityType (like instance type),
code that check for these types need to be updated.
Since the new entities are just types of templates,
and looking fwd we might add more like these,
looks like caller only want to know if this is a vm or a template.
So I added methods for easier reference,
and changed all references to specific types to the right method.
Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmEntityType.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
5 files changed, 44 insertions(+), 26 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server