Change in ovirt-engine[master]: core: validate max lun disk attachment
Roy Golan has submitted this change and it was merged.
Change subject: core: validate max lun disk attachment
......................................................................
core: validate max lun disk attachment
The check for the limit of PCI addresses was missing when adding a lun
disk.
This patch also contains some refactoring to make a clear separation between
canDo's on adding disk with and without a VM and calls the limit check
only when there is a VM in hand.
Change-Id: I4a82b3ed85c89beb8df70315ad457f54b366d69d
Bug-Url: http://bugzilla.redhat.com/876127
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
3 files changed, 107 insertions(+), 32 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a82b3ed85c89beb8df70315ad457f54b366d69d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>