Change in ovirt-engine[master]: core: ChildCommandsCallbackBase - setSucceeded(false)
Liron Aravot has submitted this change and it was merged.
Change subject: core: ChildCommandsCallbackBase - setSucceeded(false)
......................................................................
core: ChildCommandsCallbackBase - setSucceeded(false)
When the command entity is persisted, its return value is persisted as well.
If the command execute() succeeded, getReturnValue().getSucceeded() will return
true.
The command object is built from the persisted command entity, which means
that the return value will be initiated to the persisted return value, when calling
endAction() having the return value returning true value when checking
getSucceeded() might lead to wrong results.
This patch is simple and sets the succeeded flag to false to avoid that issue.
Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58010
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>