From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Mock GlusterHooksSyncJobTest@logUtil
......................................................................
core: @Mock GlusterHooksSyncJobTest@logUtil
The logUtil member is an external colaborator which may have its own
logic that isn't (or at least shouldn't) be tested in this test.
Using a @Mock object instead of a @Spy one ensures that its
implementation won't accidentally get mixed into this test.
Change-Id: I7514bbff805dcc1311c52e7162dc8be32a4c97cc
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Denis Chaplygin: Verified
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit
https://gerrit.ovirt.org/74208
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7514bbff805dcc1311c52e7162dc8be32a4c97cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>