Allon Mureinik has submitted this change and it was merged.
Change subject: core: SSH test exceptions
......................................................................
core: SSH test exceptions
A lot of the tests in the ssh package will catch any exception and
throw a RuntimeException, thus failing the test. A much cleaner
approach would be to just throw the original exception all the way
up. This way the test will still fail, but will at least provide some
useful information on why it failed.
Change-Id: I81a2661b6d3d5d48e548b90c20b53e243f0c5d68
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java
M
backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java
6 files changed, 23 insertions(+), 58 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/64108
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a2661b6d3d5d48e548b90c20b53e243f0c5d68
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>