2:53 p.m.
Juan Hernandez has submitted this change and it was merged.
Change subject: Run Rubocop as part of the 'test' task
......................................................................
Run Rubocop as part of the 'test' task
This patch fixes most of the Rubocop complaints, and disables the cops
that can't be easily addressed, so that we can actually run Rubocop on
the source as part of the 'test' task.
Note that the generated code has also been improved to generate less
Rubocop complaints (1.9 hash syntax, no return, etc), but it isn't
actually checked because it takes too long, and some complaints (long
lines, for example) are hard to avoid.
Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 4f25dd3f80efca0954984e13e41a9608a5b3fb29)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/VersionGenerator.java
M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java
A sdk/.rubocop.yml
M sdk/Gemfile
M sdk/README.adoc
M sdk/Rakefile
M sdk/examples/add_cluster.rb
M sdk/examples/add_data_center.rb
M sdk/examples/add_group.rb
M sdk/examples/add_host.rb
M sdk/examples/add_independent_vm.rb
A sdk/examples/add_mac_pool.rb
M sdk/examples/add_nfs_data_storage_domain.rb
M sdk/examples/add_nfs_iso_storage_domain.rb
M sdk/examples/add_openstack_image_provider.rb
M sdk/examples/add_vm.rb
M sdk/examples/add_vm_disk.rb
M sdk/examples/add_vm_nic.rb
M sdk/examples/add_vm_snapshot.rb
M sdk/examples/attach_nfs_data_storage_domain.rb
M sdk/examples/attach_nfs_iso_storage_domain.rb
M sdk/examples/change_vm_cd.rb
M sdk/examples/enable_compression.rb
M sdk/examples/follow_vm_links.rb
M sdk/examples/import_external_vm.rb
M sdk/examples/kerberos_authentication.rb
M sdk/examples/list_vm_disks.rb
M sdk/examples/list_vms.rb
M sdk/examples/page_vms.rb
M sdk/examples/remove_host.rb
M sdk/examples/remove_vm.rb
M sdk/examples/search_vms.rb
M sdk/examples/set_vm_serial_number.rb
M sdk/examples/show_summary.rb
M sdk/examples/start_vm.rb
M sdk/examples/stop_vm.rb
M sdk/examples/update_data_center.rb
M sdk/lib/ovirtsdk4/connection.rb
M sdk/lib/ovirtsdk4/probe.rb
M sdk/lib/ovirtsdk4/reader.rb
M sdk/lib/ovirtsdk4/service.rb
M sdk/lib/ovirtsdk4/type.rb
M sdk/lib/ovirtsdk4/writer.rb
M sdk/ovirt-engine-sdk.gemspec
M sdk/spec/action_reader_spec.rb
M sdk/spec/cluster_reader_spec.rb
M sdk/spec/clusters_service_spec.rb
M sdk/spec/connection_create_spec.rb
M sdk/spec/connection_timeout_spec.rb
M sdk/spec/connection_use_spec.rb
M sdk/spec/data_centers_service_spec.rb
M sdk/spec/enum_spec.rb
M sdk/spec/fault_reader_spec.rb
M sdk/spec/network_reader_spec.rb
M sdk/spec/network_writer_spec.rb
M sdk/spec/openstack_image_provider_writer_spec.rb
M sdk/spec/probe_spec.rb
M sdk/spec/reader_spec.rb
M sdk/spec/service_spec.rb
M sdk/spec/spec_helper.rb
M sdk/spec/storage_domain_service_spec.rb
M sdk/spec/storage_domains_service_spec.rb
M sdk/spec/type_spec.rb
M sdk/spec/vm_reader_spec.rb
M sdk/spec/vm_service_spec.rb
M sdk/spec/vm_spec.rb
M sdk/spec/vm_writer_spec.rb
M sdk/spec/vms_service_spec.rb
M sdk/spec/writer_spec.rb
M sdk/spec/xml_reader_spec.rb
M sdk/spec/xml_writer_spec.rb
74 files changed, 1,521 insertions(+), 1,852 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65708
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7268ae79cc55609b92c7cd17c71cfdcf9be9563
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>