Change in ovirt-engine[master]: core: Fix unauthorized move-disk
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix unauthorized move-disk
......................................................................
core: Fix unauthorized move-disk
When quota was set to 'Enforcing' user could move a disk to a storage
domain which he had no permissions to use.
For some reason, an 'if' statement was used in order to add the
storage-domain to the permission subject list only when quota was set to
'Disabled' or 'Audit'. 'If' statement was canceled. The
storage-domain
is added to the list when disk is about to be moved to the
storage-domain.
Change-Id: I32713cbcf3206ab449ddca9b0ebd382bf77a7582
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
4 files changed, 7 insertions(+), 41 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32713cbcf3206ab449ddca9b0ebd382bf77a7582
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>