Change in ovirt-engine[ovirt-engine-3.3]: engine: Modified network static IP validation
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Modified network static IP validation
......................................................................
engine: Modified network static IP validation
It used to not allow changing the management network's IP address
whenever the hostname was given as an IP address, but actually
problems only arise if the old management network's IP address was
equal to the hostname. However, this validation should be applied to
ANY network, not just the management network.
Also modified the tests accordingly, as well as fixed some logic that
was supposed to give existing NICs different IP addresses but I don't
think did anything.
Change-Id: I85f873fe4e87d16ec60da5bd8f9d6c90ee1e0030
Bug-Url: https://bugzilla.redhat.com/989360
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 87 insertions(+), 30 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20345
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85f873fe4e87d16ec60da5bd8f9d6c90ee1e0030
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server