Change in ovirt-engine[ovirt-engine-4.0]: webadmin: v2v -moving vms between lists got stuck

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: v2v -moving vms between lists got stuck ...................................................................... webadmin: v2v -moving vms between lists got stuck when choosing vms to import in the import VMs dialog, then clicking "Next" to next import dialog for choosing cluster and then clicking "Back" to display the first import dialog again: in this senario when moving vms from importedVmModels list to externalVmModels and vice versa, at some point clicking the arrow button does nothing (arrow button is clicked and button callback is called but VM is not moved). This problem occurred because when clicking "back" button and displaying 1st dialog, new UI objects are created for the 1st dialog (SplitTable,ImportVmsPopupView...), but the old ones for this 1st dialog are still alive and both old and new UI objects share the same model. This causes the old UI button callbacks to disrupt the data for the new UI objects. in some point when clicking on a vm to select it with checkbox, the "old" button callback calulated it as 2 vms checked although only one vm is actually checked. Trying to move this VM by clicking the arrow causes failure and nothing is moved. The fix for this bug includes reseting both importedVmModels and externalVmModels lists of the model (copying the items list only) before creating the new UI instances for the "Back" operation. Change-Id: Ib34d108a2959a50df0e39edd21360d2e5feb4f54 Bug-Url: https://bugzilla.redhat.com/1338740 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/58354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib34d108a2959a50df0e39edd21360d2e5feb4f54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;