Change in ovirt-engine[master]: core: Don't use EqOp on constants in commons
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Don't use EqOp on constants in commons
......................................................................
core: Don't use EqOp on constants in commons
This patch removes the usage on StringHelper.EqOp for string constants
from the commons package, and replaces them with the standard JDK string
equality checks such as equals and equalsIgnoreCase.
Note that the EqOp is just redundant in these cases, since a string
constant is known not to be null.
Change-Id: Id0936f213025c76b8c34df6d447e8067500a9887
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
3 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11639
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0936f213025c76b8c34df6d447e8067500a9887
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>