Change in ovirt-engine[master]: core: extract disk statistics from vm-dynamic
Arik Hadas has submitted this change and it was merged.
Change subject: core: extract disk statistics from vm-dynamic
......................................................................
core: extract disk statistics from vm-dynamic
This is quite an absurd that VmDynamic#disks was set with
@UnchangeableByVdsm although it is reported only by VDSM.
This might be an indication of a problem with the design
- it represents disk statistics and thus should not be
part of VmDynamic:
1. It is not supposed to be compared with value from the
database (hence why it is set with @UnchangeableByVdsm)
2. It is not supposed to be sent for each VM that is being
queried, including search queries.
Therefore, this patch extracts this data from VmDynamic to
VdsmVm that contains similar type of statistics.
Change-Id: I4139db014d4663c1ee1eff5037939db628b2f53e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java
6 files changed, 46 insertions(+), 63 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/63329
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4139db014d4663c1ee1eff5037939db628b2f53e
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>