Change in ovirt-engine[master]: webadmin: Showing the fault error in the multipleActions err...
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Showing the fault error in the multipleActions error dialog
......................................................................
webadmin: Showing the fault error in the multipleActions error dialog
In most of the commands the canDoActionMessages contain the '$action'
and the '$type' replacements, no matter if the canDo passed or not.
Since FrontendEventsHandlerImpl.runMultipleActionsFailed checked the
canDoActionMessages size in order to decide wherer to show the canDo
errors or the fault, the fault was rarely (if ever) displayed.
Change-Id: I91819e7d67bbd76ec7c183608e0d0abbd70908ee
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Alona Kaplan: Verified
Daniel Erez: Looks good to me, approved
Lior Vernia: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/37724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91819e7d67bbd76ec7c183608e0d0abbd70908ee
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server