Change in ovirt-engine[master]: backend: look for OVF store disks only in data domains
Tal Nisan has submitted this change and it was merged.
Change subject: backend: look for OVF store disks only in data domains
......................................................................
backend: look for OVF store disks only in data domains
OVF store disks exist only in data domains.
Thus, when we attach a storage domain to a dc, we should look for them
only if it's a data domain, and with that prevent irrelevant warning
messages from being logged.
Change-Id: I2df09e5dd76fc75af8a4ad6e6ff0bf69679799fc
Bug-Url: https://bugzilla.redhat.com/1305343
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java
2 files changed, 22 insertions(+), 19 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Maor Lipchuk: Looks good to me, but someone else must approve
Idan Shaby: Verified
Objections:
Jenkins CI: Failed CI tests
Liron Aravot: I would prefer that you didn't submit this
--
To view, visit https://gerrit.ovirt.org/53164
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2df09e5dd76fc75af8a4ad6e6ff0bf69679799fc
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>