Change in ovirt-engine[ovirt-engine-3.3]: core: fix virtio-scsi validation on update VM
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix virtio-scsi validation on update VM
......................................................................
core: fix virtio-scsi validation on update VM
Fix VirtIO-SCSI validation when updating a running VM:
* Added a new signature for vmDeviceChanged method which
gets also a specific VmDeviceType.
** Needed for using getVmDeviceByVmIdTypeAndDevice
method from VmDeviceDao. I.e. instead of fetching
all devices of VmDeviceGeneralType.CONTROLLER,
filter also by VmDeviceType.VIRTIOSCSI specifically.
* Added new test-cases for updating a running VM.
Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204
Bug-Url: https://bugzilla.redhat.com/1058295
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
2 files changed, 64 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f2247319b014f59d5c19c0054ee9e63d1dfe204
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server