Change in ovirt-engine[ovirt-engine-3.4]: webadmin: AddRemoveRowWidget to only add ghost entry if no i...
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: AddRemoveRowWidget to only add ghost entry if no items
......................................................................
webadmin: AddRemoveRowWidget to only add ghost entry if no items
If there are items in the passed collection, then there's no need to
add a ghost entry by default, but only have a plus button next to the
last entry.
Change-Id: I120e9183d739213b3a26227cc8c3b738ee3b54dc
Bug-Url: https://bugzilla.redhat.com/1020861
Bug-Url: https://bugzilla.redhat.com/1058205
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
2 files changed, 25 insertions(+), 15 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/23826
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I120e9183d739213b3a26227cc8c3b738ee3b54dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server