From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Move initialization in LiveMigrateDiskCommand to init block
......................................................................
core: Move initialization in LiveMigrateDiskCommand to init block
LiveMigrateDiskCommand CTOR is calling getVm() which triggers a DAO call,
those calls in the command classes are now using the DAOs by injection and
since injection is performed after the CTOR is invoked the DAOs will be
null.
Moved the initialization part from the CTOR to the init block where it
belonds to avoid the NPE caused.
Change-Id: Idbc71d59f8c2f47e320bed2b98056fa102fa84db
Bug-Url:
https://bugzilla.redhat.com/1395746
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/66890
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbc71d59f8c2f47e320bed2b98056fa102fa84db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>