Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Improve GWT UI build logs
......................................................................
webadmin,userportal: Improve GWT UI build logs
This patch tries to make GWT UI build logs less confusing.
All changes below apply *only* to JVM running GWT compiler,
which is spawned by gwt-maven-plugin during the Maven build.
1. Use custom AspectJ load-time-weaver message handler in
aop.xml that prints logs to std-out instead of std-err.
(mvn) logs before:
[ERROR] [..] info AspectJ Weaver Version ..
[ERROR] [..] info register classloader ..
[ERROR] [..] info using configuration ..
[ERROR] [..] info register aspect ..
(mvn) logs now:
[INFO] info AspectJ Weaver Version ..
[INFO] info register classloader ..
[INFO] info using configuration ..
[INFO] info register aspect ..
2. Use custom java.util.logging configuration that
prints logs to std-out instead of std-err.
(mvn) logs before:
[ERROR] .. java.util.prefs.FileSystemPreferences..
[ERROR] INFO: Created user preferences directory.
(mvn) logs now:
[INFO] .. java.util.prefs.FileSystemPreferences..
[INFO] INFO: Created user preferences directory.
3. Added TODO in frontend aggregator module's pom.xml
about aop.xml being applied twice (not a big deal,
we can address this in future)
Change-Id: I1fed599a1190ceff6c5dc8bf6fab6f6e499bec1f
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
A
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/gwtextension/AspectJLogHandler.java
A
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/gwtextension/JavaLoggingConfig.java
M frontend/webadmin/modules/gwt-extension/src/main/resources/META-INF/aop.xml
M frontend/webadmin/modules/pom.xml
6 files changed, 71 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Tal Nisan: Looks good to me, approved
Daniel Erez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
Vojtech Szocs: Verified
--
To view, visit
https://gerrit.ovirt.org/50545
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fed599a1190ceff6c5dc8bf6fab6f6e499bec1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>