Change in ovirt-guest-agent[master]: win32: Set registry value with SetValueEx not SetValue
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: win32: Set registry value with SetValueEx not SetValue
......................................................................
win32: Set registry value with SetValueEx not SetValue
_winreg.SetValue only allows to set the default value on a subkey
SetValueEx lets one specify the value name and the value itself.
Additionally as a security measure we're now encapsulating all
exceptions coming from SAS handling to still at least attempt the
login, even if the SAS portion may fail.
This is just a precaution to prevent SSO from breaking due to some
unforeseen bug.
Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54
Bug-Url: https://bugzilla.redhat.com/1158470
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51d70381de43d62e96f9f24de60bdf0226e20f54
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server