Change in ovirt-engine[master]: core: Removed unnecessary calls to StringFormat & StringHelp...
Tal Nisan has submitted this change and it was merged.
Change subject: core: Removed unnecessary calls to StringFormat & StringHelper
......................................................................
core: Removed unnecessary calls to StringFormat & StringHelper
Replaced calls to StringFormat.format to String.format where possible
(i.e. not code that compiles to GWT) and to simple String concatenation where
possible.
Also replaced calls to StringHelper.EqOp calls in
String.equals calls in cases that at least one of the args was not null.
Added @Override annotation to methods in the edited classes where needed
Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java
M
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringFormat.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java
8 files changed, 48 insertions(+), 55 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57dc0d9d30f9e5cd4f0beacc8bfd35fe5023afc1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>