Change in ovirt-engine[master]: engine: Improving memory footprint - JSON part
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Improving memory footprint - JSON part
......................................................................
engine: Improving memory footprint - JSON part
The following patch should imprtove a used memory in all work related to JSON.
The scenarious which will be improved: all scenarios which are using compensation and vm
monitoring.
Motivation is due to wiki of Jackson serializer it is thread safe, except configuration
part,
but we are not changing configuration (Also I did short code review in order to verify
that ObjectMapper is thread safe)
ObjectMapper is not lightweight object and also has some internal cache in order to
improve it performance, so
a change is obvious: serializer and desirializer which are based on ObjectMapper should be
single instance.
Change-Id: I11a76b46a5bfa269605249c3dfc2d69a55d8bbef
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SerializationFactory.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
7 files changed, 72 insertions(+), 74 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11a76b46a5bfa269605249c3dfc2d69a55d8bbef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>