Change in ovirt-engine[master]: webadmin, userportal: Improve GIN bindings/injections
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Improve GIN bindings/injections
......................................................................
webadmin,userportal: Improve GIN bindings/injections
1. added BaseSystemModule.bindTypeAndImplAsSingleton
method and used it for following bindings:
- place manager
- all resources (constants, messages, etc.)
i.e. injecting CommonApplicationConstants and
app-specific ApplicationConstants now yields the
same singleton (ApplicationConstants) instance
2. modified classes to inject ClientAgentType instead
of doing "new ClientAgentType" on their own
Change-Id: I09a0178171de3f4e698e616a78ca988f47436957
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
4 files changed, 23 insertions(+), 14 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09a0178171de3f4e698e616a78ca988f47436957
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server