Change in ovirt-engine[master]: sercon: minor ovirt-vmconsole-list.py cleanups
Sandro Bonazzola has submitted this change and it was merged.
Change subject: sercon: minor ovirt-vmconsole-list.py cleanups
......................................................................
sercon: minor ovirt-vmconsole-list.py cleanups
- add debug command line option
- leverage ovirt-configured logging
- use specific logger: was using top level logger (logging.something())
because of a typo.
- make sure we close the file-like returned by urllib2.
- make sure to logs exceptions on syslog
Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py
1 file changed, 37 insertions(+), 18 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/44176
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5323da99c2709b51fe043b492860140aad5af5a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org