7:57 p.m.
Daniel Erez has submitted this change and it was merged.
Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache
......................................................................
core,webadmin: GetConfigurationValuesQuery for UI cache
Added 'GetConfigurationValuesQuery' for fetching and caching all
configuration values (ConfigurationValues enum) on UI startup.
Apart of the obvious performance improvement, using a single query
for retrieval (instead of a query for each value), results in a
simpler/cleaner UI code.
Core:
* GetConfigurationValuesQuery - new query
* Version - added 3_2 constant and 'ALL' version list for query's usage.
* DBConfigUtils - lowered some logs from 'warn' to 'debug' for
preventing redundant warnings on each query's execute.
* Removed redundant ConfigurationValues (missing in ConfigValues enum):
ExportDefaultPath and IrsClusterStatusRefreshRate.
* Added ConfigValuesTest for finding missing enum names
(exist in ConfigurationValues but missing in ConfigValues enum).
UI:
* AsyncDataProvider:
** CacheConfigValues - caching the 'pre-converted (raw)'
configuration values returned from 'GetConfigurationValuesQuery'.
** GetConfigValue - getting a raw configuration value from the cache
(for future usage - requires value conversion if needed).
** GetConfigFromCache - removed legacy 'GetConfigurationValue' call.
* LoginModel/UserPortalLoginModel - caching values after login.
* DataCenterNetworkListModel/HostInterfaceListModel -
'GetManagementNetworkName' call has relied on the fact that
the query returns asynchronously - caused a NPE on startup.
* DataProvider - removed redundant ConfigurationValues getter.
Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
A
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/ConfigValuesTest.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
12 files changed, 214 insertions(+), 68 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>