Simone Tiraboschi has submitted this change and it was merged.
Change subject: setup: ask host address on additional hosts
......................................................................
setup: ask host address on additional hosts
Use hostname.getHostname from ovirt_setup_lib
to ask and validate the host address on additional
host.
On the first host we already ask the management
interface to create the management bridge on
and so we can only take the address that uniquely
resolves there.
On additional hosts we simply rely on host-deploy
to create the management bridge on the interface
where the address supplied to hosts.add resolves on
and so it's worth to ask the user with a reasonable
default.
Change-Id: Ic5ce041e47fef02d60aa46159ff56f9e0622d5fc
Bug-Url:
https://bugzilla.redhat.com/1251968
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-setup/network/bridge.py
1 file changed, 21 insertions(+), 3 deletions(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/49310
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5ce041e47fef02d60aa46159ff56f9e0622d5fc
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>