From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set qcow compat for floating QCOW volumes.
......................................................................
core: Set qcow compat for floating QCOW volumes.
Unregistered disks should be set with QCOW compat returned from the
storage domain.
Addition to this fix are the following changes:
1) use the register with multiple action to prevent a
use case which VDSM will be non responsive.
2) Use non transactive in register disk so VDSM call will not hang the
transaction.
3) Adding an audit log indicating the initial of register disk.
Change-Id: I45f10a82fdf05737c952a6ffdbf0aaab48de9ff4
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDiskQuery.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterDiskModel.java
5 files changed, 97 insertions(+), 18 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/75374
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45f10a82fdf05737c952a6ffdbf0aaab48de9ff4
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>