Omer Frenkel has submitted this change and it was merged.
Change subject: core: cleanup in ovf readers where hardware is read
......................................................................
core: cleanup in ovf readers where hardware is read
This patch reduces the duplicated code in template's OVF reader and VM's
OVF reader which is related to the reads of the hardware section.
The common code is now in OvfReader, and OvfTemplateReader & OvfVmReader
overrides it when needed.
Change-Id: Ia44e11f4c6eca2dc47ed2ee24bd855d7888fe015
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
3 files changed, 144 insertions(+), 213 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit
http://gerrit.ovirt.org/29841
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia44e11f4c6eca2dc47ed2ee24bd855d7888fe015
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server