Change in ovirt-engine[master]: webadmin: improve behavior of bookmark list (2/2)
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: improve behavior of bookmark list (2/2)
......................................................................
webadmin: improve behavior of bookmark list (2/2)
This patch series fixes some problems with the behavior of the bookmark
list. This patch fixes re-selection of already-selected bookmarks,
which was broken by gwt issue 6310 (which causes setSelectedItem to not
behave as expected when a SingleSelectionModel's keyboardSelectionPolicy
is BOUND_TO_SELECTION).
To work around the problem, we use a different keyboardSelectionPolicy
that isn't affected by the bug, and handle the keypress events manually.
Change-Id: I25a9e721d8b7ccd982708eadf579e9eb229dedd5
Bug-Url: https://bugzilla.redhat.com/880499
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/bookmark/BookmarkList.java
1 file changed, 36 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10819
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25a9e721d8b7ccd982708eadf579e9eb229dedd5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>