Change in ovirt-engine[master]: core: move the validation of active iso domain on run vm
Omer Frenkel has submitted this change and it was merged.
Change subject: core: move the validation of active iso domain on run vm
......................................................................
core: move the validation of active iso domain on run vm
The validation which checks that there is an active ISO domain when the
VM is configured with 'iso path' was located in RunVmCommand, while it
should be located in RunVmValidator. Besides moving that validation to
the RunVmValidator class, a minor improvement is introduced: instead of
searching the id of the active ISO domain each time we need it (and
we're planning to use it more soon), it is now cached for the lifetime
of the RunVm command.
Change-Id: Ic1bc81686be01088aa2dde5c61e4b83c96643f73
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java
4 files changed, 48 insertions(+), 56 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/21206
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1bc81686be01088aa2dde5c61e4b83c96643f73
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server