Change in ovirt-engine[master]: packaging: setup: support lexical parsing of configuration
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: setup: support lexical parsing of configuration
......................................................................
packaging: setup: support lexical parsing of configuration
the configuration file format is shell like format, it should be parsed
by shell, python and java.
current implementation does not parse the value using lexical method, so
escape of characters is impossible, and there may be other side effects
like comments that should remain within quotes.
new implementation uses primitive but sufficient parsing of literals.
sync implementation between java and python and sync implementation of
service parser to match this of setup.
Change-Id: I945c8ddbe5de512ab330153c27802bb71964b76f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
A
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/LocalConfigTest.java
A backend/manager/modules/utils/src/test/resources/localconfig.conf
A backend/manager/modules/utils/src/test/resources/localconfig.conf.ref
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-upgrade.py
M packaging/services/ovirt-engine-logging.properties.in
M packaging/services/ovirt-engine-notifier.py
M packaging/services/ovirt-engine.py
M packaging/services/ovirt-engine.xml.in
M packaging/services/ovirt-websocket-proxy.py
M packaging/services/service.py
M packaging/setup/ovirt_engine_setup/util.py
M packaging/setup/plugins/ovirt-engine-setup/config/ca.py
M packaging/setup/plugins/ovirt-engine-setup/config/database.py
15 files changed, 417 insertions(+), 260 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I945c8ddbe5de512ab330153c27802bb71964b76f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>